Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement better __type__.name type inference + infer result of polymorphic queries as discriminated union #508

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Implement better __type__.name type inference + infer result of polymorphic queries as discriminated union #508

wants to merge 2 commits into from

Conversation

jaclarke
Copy link
Member

Closes #454

@jaclarke
Copy link
Member Author

Suggestion from Elvis: Now the v2 type descriptors contain type ids/names, we should query the typeid, and conditionally convert that to the typename client side to avoid performance penalty of joining types on the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinhacks colinhacks Awaiting requested review from colinhacks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better return types for .__type__.name and polymorphic queries if possible
1 participant
@jaclarke