Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to eslint #1020

Closed
wants to merge 14 commits into from
Closed

Transition to eslint #1020

wants to merge 14 commits into from

Conversation

diksipav
Copy link
Contributor

@diksipav diksipav commented May 13, 2024

NOTE: I suggest reviewing commit by commit.

I added the config (eslint.config) for eslint v9 with flat config.

I fixed majority of errors throughout the codebase. And hopefully any types in Remix auth lib.

But definitely a good review is needed of the changes I made.

And there are some errors I wasn't sure about how to fix and also many other any type warnings.

I left todo comments somewhere where I wasn't sure if my "fix" is good enough.

More info: here are ts-eslint
recommended rules,
recommended-type-checked rules,
strict,
strict-type-checked,
stylistic,
stylistic-type-checked.

EDIT:
I removed stylistic "@typescript-eslint/class-literal-property-style" rule because it is enforcing readonly field class literal values, and we use getters in many places (which is actually safer).

TODO:
Check packages/generate/src/syntax/castMaps.ts. Not sure what's this file and how to fix it.

@diksipav diksipav marked this pull request as draft May 13, 2024 14:25
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/driver/src/errors/base.ts Outdated Show resolved Hide resolved
packages/generate/src/builders.ts Outdated Show resolved Hide resolved
packages/generate/src/edgeql-js.ts Outdated Show resolved Hide resolved
packages/generate/src/syntax/insert.ts Outdated Show resolved Hide resolved
@scotttrinh
Copy link
Collaborator

scotttrinh commented May 14, 2024

We also want to:

@diksipav diksipav closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants