Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): Added ability to clear select #412

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

avaneev95
Copy link
Contributor

@avaneev95 avaneev95 commented Sep 2, 2018

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • linted, built and tested the changes locally.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

This PR adds a isClearable property to the SuiSelect to allow the ability to deselect an option.
It can be useful if you are using a select as a filter and want the ability to reset it.

Here the example:
clearable-select

@marcbernal
Copy link

Hi, do you have any estimation on when will this PR be merged ?

<sui-select class="selection"
[(ngModel)]="selectedOption"
[options]="filters"
[isClearable]="true"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this fix in old version ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants