New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Rating component #366

Open

icharge wants to merge 1 commit into edcarroll:master from icharge:icharge-patch-1

icharge commented Mar 25, 2018

Rating component value @Input() is missing

Before submitting a pull request, please make sure you have at least performed the following:

read and followed the CONTRIBUTING.md guide.
linted, built and tested the changes locally.
added/updated any applicable API documentation.
added/updated any applicable demos.


          Fix Rating component

91131b1

Rating component value `@Input()` is missing

arutkowski00 mentioned this pull request

Fix Rating component yhnavein/ng2-semantic-ui#3

Merged

Owner

edcarroll commented Aug 23, 2018

I'm not sure this is necessary - doesn't using the ngModel bindings achieve the desired effect?

edcarroll added the state: revisit label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment