fix es modules #96
Open
fix es modules #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@junmer it would be really nice if you'd like to release this. The CLI is broken in version 0.9.9. Let me know if I can help. |
|
@mkwiser Please merge the requeset and release a version 1.0.0 |
Open
|
This now unfortunately conflicts after the 1.0.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on my Node 14.17.6 env the CLI version doesn't work due to ES module-only dependencies (
meow) which don't support node's require.I've refactored everything to ES modules. This will break support for older node versions (< 12?), but recent dependency bumps broke that anyway. If you accept the change, it might be good to release this as 0.10 though?
The only (temporary) concession I had to make is the dynamic import of plugins. I've hardcoded them for now, but ideally that should be refactored to
await import.@junmer what do you think?