Fix css selector #38
Open
Fix css selector #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was ":after", should be ":before", because that's where the glyphs are rendered. Fixes ecomfe#37.
Actually the entire ":before" selector is unnecessary, removing it will still render icons correctly (as long as the span itself is left empty, which is how it should be used).
|
Is this repository still being monitored? It would be nice if this 9 month old PR could be merged, or commented on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was ":after", will work better with ":before" (see #37), but removing the selector entirely yields correct results as well, and is in fact more or less how Glyphicon works in Bootstrap.