Use AndroidHighResolutionTimer for elapsed time #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This timer uses SystemClock.elapsedRealtimeNanos to calculate the high resolution timing value, which advances time when the device is asleep. Fixes a bug introduced by the paho.mqtt.java library when it was changed to track elapsed time using System.nanoTime. However, on android, nanoTime does not advance when the device is in a deep sleep. As a result, pings may not be sent frequently enough, resulting in client disconnects. See: eclipse/paho.mqtt.java#278 eclipse/paho.mqtt.java#774 Signed-off-by: Dustin Thomson <dthomson@51systems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This timer uses SystemClock.elapsedRealtimeNanos to calculate the high
resolution timing value, which advances time when the device is asleep.
Fixes a bug introduced by the paho.mqtt.java library when it was changed
to track elapsed time using System.nanoTime. However, on android,
nanoTime does not advance when the device is in a deep sleep. As a
result, pings may not be sent frequently enough, resulting in client
disconnects.
See:
eclipse/paho.mqtt.java#278
eclipse/paho.mqtt.java#774
Signed-off-by: Dustin Thomson dthomson@51systems.com
Please make sure that the following boxes are checked before submitting your Pull Request, thank you!