Change TR_ASSERT_FATAL to static_assert in TR_AliasSetInterface #7327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch elimates use of TR_ASSERT_FATAL to static assert in AliasSetInterface.hpp Issue: eclipse#4933
0xdaryl
reviewed
May 28, 2024
compiler/il/AliasSetInterface.hpp
Outdated
| @@ -24,6 +24,7 @@ | |||
|
|
|||
| #include <stddef.h> | |||
| #include <stdint.h> | |||
| #include <cassert> | |||
There was a problem hiding this comment.
static_assert is a keyword and does not require an include
|
Also, please fix spelling in your commit body message. Perhaps reword to: Replace some uses of TR_ASSERT_FATAL with static_assert in AliasSetInterface.hpp |
Replace some uses of TR_ASSERT_FATAL with static_assert in AliasSetInterface.hpp Issue: eclipse#4933
|
Sorry, I will request new PR |
|
Close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch elimates use of TR_ASSERT_FATAL to static assert in AliasSetInterface.hpp
Issue: #4933