Refactor SIMPLIFY_BRANCH_ARITHMETIC Macro #7307
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the SIMPLIFY_BRANCH_ARITHMETIC and replaces it with a templated instantiation that seeks to emulate a closure. The templated class is provided with the mutators and accessors for nodes so tha tthe notation of passing in getter names through the macro is no longer needed The logic from the original macro to check whether a node is a viable candidate for simplification and which optimization to perform is simplified. The old macro also contained side effects which modified the local variables at the call site and this has been removed and replaced with equivalent semantics. Signed-off-by: James You <james.you@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the SIMPLIFY_BRANCH_ARITHMETIC and replaces it with a templated instantiation that seeks to emulate a closure. The templated class is provided with the mutators and accessors for nodes so tha tthe notation of passing in getter names through the macro is no longer needed
The logic from the original macro to check whether a node is a viable candidate for simplification and which optimization to perform is simplified.
The old macro also contained side effects which modified the local variables at the call site and this has been removed and replaced with equivalent semantics.