Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config options to decrease ACK rates #403

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add config options to decrease ACK rates #403

wants to merge 2 commits into from

Conversation

trickapm
Copy link

A number of config options have been added for tweaking the protocol between reliable readers/writers to decrease ACK rates.

  • Disable ParticipantMessageData readers (which trigger creation of matching writers) to disable periodical liveliness messages and associated ACK traffic. Liveliness is still derived indirectly from other traffic.
  • Option for ACK suppression that makes reliable writers send heartbeats with ACK requests only if neccesary eg. to clean up writer-history cache (suppressing ACKs when 'all is well').
  • Option for (randomized) ACK delay to prevent all relevant readers from responding to ACK requests at the same time causing spikes on the network.

All options are by default turned off so unless explicitly configured the default behaviour is unchanged.

@trickapm
Fix deletion of options doc custom_command output if comparison fails
5b685f2 
If DDSI config options are changed, some generated files (options.md, cyclonedds.rnc, cyclonedds.xsd) will not match the ones in git. By moving the comparison from a custom command to a custom target, the files will not get deleted if the comparison fails. This allows them to be copied over to replace the ones in git.

Signed-off-by: Patrick Masselink <patrick@patmas.net>
@trickapm
Add config options to decrease ACK rates of reliable readers
87f82eb 
Three config options have been added to tune behaviour of reliable
readers/writers (see options.md for details), none of which are enabled
by default

Signed-off-by: Patrick Masselink <patrick@patmas.net>
@k0ekk0ek
Copy link
Contributor

@eboasson, is this something we're interested in? If so, @trickapm, maybe you can update after #487 has been merged? Sorry nobody looked into this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@trickapm @k0ekk0ek