Add Slack channel name to actions description #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@i5o would you remind rebasing this and updating the version? |
|
@echoboomer done ;) |
echoboomer
requested changes
May 23, 2024
| @@ -94,7 +94,8 @@ def create( | |||
| "text": { | |||
| "type": "mrkdwn", | |||
| "text": "A new incident has been declared. " | |||
| + "Please use the buttons here to participate.", | |||
| + "Please use the buttons here to participate." | |||
| + f"\n#{incident_channel_details.get("name")}", | |||
There was a problem hiding this comment.
You'll need to use single quotes here around name.
i5o
commented
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue number and link
Checklist before requesting a review
./scripts/version-bump.sh v<new>from project root - for example./scripts/version-bump.sh v1.9.3