Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

versions checks to avoid mixing major versions across the EasyBuild components #4520

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

versions checks to avoid mixing major versions across the EasyBuild components #4520

wants to merge 12 commits into from

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Apr 27, 2024 •
edited

This PR will add various version checks and is EB5 prep for the EB4 branch.

  • check that framework and blocks major versions are the same and fails if not
  • check --from-pr / --include-easyblocks-from-pr branches match in use versions

@branfosj branfosj added this to the release after 4.9.1 milestone Apr 27, 2024
@branfosj branfosj marked this pull request as draft April 27, 2024 14:24
@branfosj branfosj changed the title check easyblocks and framework major are the same versions checks to avoid mixing major versions across the EB repositories Apr 27, 2024
boegel
boegel requested changes Apr 29, 2024
View reviewed changes
easybuild/tools/version.py Outdated Show resolved Hide resolved
easybuild/main.py Outdated Show resolved Hide resolved
@branfosj branfosj marked this pull request as ready for review May 6, 2024 13:27
@boegel boegel changed the title versions checks to avoid mixing major versions across the EB repositories versions checks to avoid mixing major versions across the EasyBuild components May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boegel boegel boegel requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
release after 4.9.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@branfosj @boegel