Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code cleanup in easyblock.py #4519

Merged
merged 1 commit into from May 22, 2024

Conversation

Flamefire
Copy link
Contributor

  • Remove pass statements where not required
  • Enhance docstrings
  • Use .items when values of dict is used (faster, clearer)
  • basename instead of split()[-1]

- Remove `pass` statements where not required
- Enhance docstrings
- Use `.items` when values of dict is used (faster, clearer)
- `basename` instead of `split()[-1]`
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the release after 4.9.1 milestone May 22, 2024
@boegel boegel changed the title Simplify easyblock.py code cleanup in easyblock.py May 22, 2024
@boegel boegel merged commit ae29588 into easybuilders:develop May 22, 2024
40 checks passed
@Flamefire Flamefire deleted the refactor-easyblock branch May 22, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants