Improve download logging #4518
Open
Improve download logging #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment about extensions doesn't really apply to the actual behavior. So give all information we can about what would happen.
No need to duplicate logic of failed downloads.
We want to check for a true-ish value and both `None` and the empty string are considered false, so shorten the condition
Put the warning-only branch first to avoid the need for `not ...` In both code paths the same message should be used, so do that more clearly. This also avoids an awkward substitution of percent signs.
Flamefire
force-pushed
the
improve_download_logging
branch
from
eecded8
to
8519a24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log all URLs and remove the "Downloaded ..." message in dry-run mode
Also some refactoring to make the code easier to read/maintain like moving loop invariants out of the loop and using a common variable for the error and warning message.