Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stability of reproducible tarballs from git repos #4517

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

lexming
Copy link
Contributor

@lexming lexming commented Apr 26, 2024

Following some test failures with our build bots (see easybuilders/easybuild-easyconfigs#19770), I found out that the tarballs of git repos are not fully reproducible as they dependent on some local settings of the host system:

  1. resetting file modification times with touch -t depends on the local timezone
  2. some file permissions of the cloned repository depend on default directory permissions

This PR fixes both issues:

  1. reset file modification times with touch --date and using unix epoch zero
  2. always remove write permissions from group and others (follows recommendation in https://www.gnu.org/software/tar/manual/html_node/Reproducibility.html)

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the 5.0 milestone Apr 26, 2024
@boegel boegel merged commit 5f0ffd7 into easybuilders:5.0.x Apr 26, 2024
35 checks passed
@lexming lexming deleted the fix-repro-tar branch April 26, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants