New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for alternate easyconfig parameters/templates/constants #4511
Draft
jfgrimm
wants to merge
23
commits into
easybuilders:5.0.x
Choose a base branch
from
jfgrimm:alternate-names
base: 5.0.x
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+225
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfgrimm
commented
Apr 19, 2024
jfgrimm
force-pushed
the
alternate-names
branch
from
April 22, 2024 05:54
262118a
to
75ab7b8
Compare
jfgrimm
force-pushed
the
alternate-names
branch
from
April 22, 2024 06:11
75ab7b8
to
72291c8
Compare
not really sure what I've done wrong, it works when you run the test in isolation...
|
…& co by simply reloading easyconfig.templates and easyconfig.easyconfig modules
…oading, since that messes up isinstance checks using EasyConfig class
…ed_easyconfig_parameters to prevent cross-test leaking
…ating of easyconfig parameter values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in slack, this is an alternative approach to introducing new parameters and deprecating old ones in one go. Instead, it's a multi-stage process:
This would allow is to do it iteratively across the different parameters / etc. over a series of EB 5.x releases.
#4464
To play around with this, check out the branch and modify:
easybuild/framework/easyconfig/parser.py
:easybuild/framework/easyconfig/templates.py
: