New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make module-extensions true by default #4501
base: 5.0.x
Are you sure you want to change the base?
Conversation
I'm very confused, out of the type of tests i expected to see failing, the one that actually broke is test_exts_list, the one the test is supposed to already be using this feature to see the list of extensions?? And It fails because it is missing homepage field.
I can only assume this test was never actually running properly then? Confusing. |
9b45800
to
cb6eb4b
Compare
oh, it's just the test that is super misleading, issue has nothing to do with homepage. It was just due to the partial template resolving code that get_description attempts for some reason. I think it started from needlessly using template to put in the |
Old method needlessly involved template resolutions, duplicating the template resolving code, but only partially and would break if anything but the 4 most common templates were used.
cb6eb4b
to
3170d9f
Compare
I'm struggling with the test suite, because of the already existing bug that breaks --module-extensions=True.
|
fixes #4396