Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace SQLAlchemy extension with regular dependency in easyconfig for Optuna v3.5.0 #20510

Merged

Conversation

lexming
Copy link
Contributor

@lexming lexming commented May 10, 2024

(created using eb --new-pr)

@lexming lexming added the change label May 10, 2024
@lexming lexming changed the title replace SQLAlchemy extension with regular dependency on Optuna v3.5.0 Optuna v3.5.0: replace SQLAlchemy extension with regular dependency May 10, 2024
@lexming
Copy link
Contributor Author

lexming commented May 10, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on login1

PR test command 'EB_PR=20510 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20510 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13444

Test results coming soon (I hope)...

- notification for comment with ID 2104801026 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f4e4ac634753c86211f7c05a3be03214 for a full test report.

@lexming
Copy link
Contributor Author

lexming commented May 10, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@lexming: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20510 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20510 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4103

Test results coming soon (I hope)...

- notification for comment with ID 2105348388 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/ad11b1c316b58d72c0e09ec56a254dfb for a full test report.

@smoors smoors added this to the release after 4.9.1 milestone May 13, 2024
Copy link
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Contributor

smoors commented May 13, 2024

Going in, thanks @lexming!

@smoors smoors merged commit 51d2d0c into easybuilders:develop May 13, 2024
9 checks passed
@lexming lexming deleted the 20240510165842_new_pr_Optuna350 branch May 13, 2024 13:07
@boegel boegel changed the title Optuna v3.5.0: replace SQLAlchemy extension with regular dependency replace SQLAlchemy extension with regular dependency in easyconfig for Optuna v3.5.0 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants