Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lang}[GCCcore/13.2.0] Python v3.12.3 #20407

Closed

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Apr 20, 2024

(created using eb --new-pr)

This PR shows what is required to build Python 3.12, but we do not want a second Python version against GCCcore/13.2.0 - so PR closed.

  • Rebuild ncurses with the changes from install pkg-config files for GCCcore builds of ncurses 6.4 #20405, so that the Python configure correctly detects the ncursesw
  • Tk / Tcl added as deps, as the internal tkinter modules looks to be required instead of optional now
  • EB5 branches set 'use_pip': True, in exts_default_options if installing in develop and remove this for EB5.

@branfosj
Copy link
Member Author

@boegelbot please test @ jsc-zen3
CORE_CNT=16

@branfosj branfosj marked this pull request as draft April 20, 2024 18:07
@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20407 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20407 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4014

Test results coming soon (I hope)...

- notification for comment with ID 2067744607 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

boegelbot commented Apr 20, 2024

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/1f6d22f71d6f4553646397341d197e5b for a full test report.

this is how it fails without rebuilding `ncurses` from #20405
gcc -I./Modules/_sqlite -fno-strict-overflow -DNDEBUG -g -O3 -Wall -O2 -ftree-vectorize -march=native -fno-math-errno -fPIC -O2 -ftree-vectorize -march=native -fno-math-errno -fPIC  -fno-semantic-interposition -flto -fuse-linker-plugin -ffat-lto-objects -flto-partition=none -g -std=c11 -Werror=implicit-function-declaration -fvisibility=hidden -fprofile-generate -I./Include/internal  -I. -I./Include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/OpenSSL/1.1/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/Tk/8.6.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/Tcl/8.6.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/libffi/3.4.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/XZ/5.4.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/SQLite/3.43.1-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/ncurses/6.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/libreadline/8.2-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/zlib/1.2.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/bzip2/1.0.8-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/binutils/2.40-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/pkgconf/2.0.3-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/OpenSSL/1.1/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/Tk/8.6.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/Tcl/8.6.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/libffi/3.4.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/XZ/5.4.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/SQLite/3.43.1-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/ncurses/6.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/libreadline/8.2-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/zlib/1.2.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/bzip2/1.0.8-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/binutils/2.40-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/pkgconf/2.0.3-GCCcore-13.2.0/include -fPIC -fPIC -c ./Modules/_sqlite/connection.c -o Modules/_sqlite/connection.o
./Modules/_cursesmodule.c: In function _curses_window_addch_impl:
./Modules/_cursesmodule.c:763:9: error: implicit declaration of function setcchar; did you mean getwchar? [-Werror=implicit-function-declaration]
  763 |         setcchar(&wcval, wstr, attr, PAIR_NUMBER(attr), NULL);
      |         ^~~~~~~~
      |         getwchar
./Modules/_cursesmodule.c:765:19: error: implicit declaration of function mvwadd_wch; did you mean mvwaddch? [-Werror=implicit-function-declaration]
  765 |             rtn = mvwadd_wch(self->win,y,x, &wcval);
      |                   ^~~~~~~~~~
      |                   mvwaddch
./Modules/_cursesmodule.c:767:19: error: implicit declaration of function wadd_wch; did you mean waddch? [-Werror=implicit-function-declaration]
  767 |             rtn = wadd_wch(self->win, &wcval);
      |                   ^~~~~~~~
      |                   waddch
./Modules/_cursesmodule.c: In function _curses_window_addstr_impl:
./Modules/_cursesmodule.c:847:19: error: implicit declaration of function mvwaddwstr; did you mean mvwaddstr? [-Werror=implicit-function-declaration]
  847 |             rtn = mvwaddwstr(self->win,y,x,wstr);
      |                   ^~~~~~~~~~
      |                   mvwaddstr
./Modules/_cursesmodule.c:849:19: error: implicit declaration of function waddwstr; did you mean waddstr? [-Werror=implicit-function-declaration]
  849 |             rtn = waddwstr(self->win,wstr);
      |                   ^~~~~~~~
      |                   waddstr
./Modules/_cursesmodule.c: In function _curses_window_addnstr_impl:
./Modules/_cursesmodule.c:930:19: error: implicit declaration of function mvwaddnwstr; did you mean mvwaddnstr? [-Werror=implicit-function-declaration]
  930 |             rtn = mvwaddnwstr(self->win,y,x,wstr,n);
      |                   ^~~~~~~~~~~
      |                   mvwaddnstr
./Modules/_cursesmodule.c:932:19: error: implicit declaration of function waddnwstr; did you mean waddnstr? [-Werror=implicit-function-declaration]
  932 |             rtn = waddnwstr(self->win,wstr,n);
      |                   ^~~~~~~~~
      |                   waddnstr
./Modules/_cursesmodule.c: In function _curses_window_get_wch_impl:
./Modules/_cursesmodule.c:1503:14: error: implicit declaration of function wget_wch; did you mean wgetch? [-Werror=implicit-function-declaration]
 1503 |         ct = wget_wch(self->win ,&rtn);
      |              ^~~~~~~~
      |              wgetch
./Modules/_cursesmodule.c:1506:14: error: implicit declaration of function mvwget_wch; did you mean mvwgetch? [-Werror=implicit-function-declaration]
 1506 |         ct = mvwget_wch(self->win, y, x, &rtn);
      |              ^~~~~~~~~~
      |              mvwgetch
gcc -I./Modules/_sqlite -fno-strict-overflow -DNDEBUG -g -O3 -Wall -O2 -ftree-vectorize -march=native -fno-math-errno -fPIC -O2 -ftree-vectorize -march=native -fno-math-errno -fPIC  -fno-semantic-interposition -flto -fuse-linker-plugin -ffat-lto-objects -flto-partition=none -g -std=c11 -Werror=implicit-function-declaration -fvisibility=hidden -fprofile-generate -I./Include/internal  -I. -I./Include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/OpenSSL/1.1/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/Tk/8.6.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/Tcl/8.6.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/libffi/3.4.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/XZ/5.4.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/SQLite/3.43.1-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/ncurses/6.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/libreadline/8.2-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/zlib/1.2.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/bzip2/1.0.8-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/binutils/2.40-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/pkgconf/2.0.3-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/OpenSSL/1.1/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/Tk/8.6.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/Tcl/8.6.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/libffi/3.4.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/XZ/5.4.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/SQLite/3.43.1-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/ncurses/6.4-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/libreadline/8.2-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/zlib/1.2.13-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/bzip2/1.0.8-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/binutils/2.40-GCCcore-13.2.0/include -I/project/def-maintainers/boegelbot/rocky9/zen3/software/pkgconf/2.0.3-GCCcore-13.2.0/include -fPIC -fPIC -c ./Modules/_sqlite/cursor.c -o Modules/_sqlite/cursor.o
./Modules/_cursesmodule.c: In function _curses_window_insstr_impl:
./Modules/_cursesmodule.c:1848:19: error: implicit declaration of function mvwins_wstr; did you mean mvwinsstr? [-Werror=implicit-function-declaration]
 1848 |             rtn = mvwins_wstr(self->win,y,x,wstr);
      |                   ^~~~~~~~~~~
      |                   mvwinsstr
./Modules/_cursesmodule.c:1850:19: error: implicit declaration of function wins_wstr; did you mean winsstr? [-Werror=implicit-function-declaration]
 1850 |             rtn = wins_wstr(self->win,wstr);
      |                   ^~~~~~~~~
      |                   winsstr
./Modules/_cursesmodule.c: In function _curses_window_insnstr_impl:
./Modules/_cursesmodule.c:1933:19: error: implicit declaration of function mvwins_nwstr; did you mean mvwinsnstr? [-Werror=implicit-function-declaration]
 1933 |             rtn = mvwins_nwstr(self->win,y,x,wstr,n);
      |                   ^~~~~~~~~~~~
      |                   mvwinsnstr
./Modules/_cursesmodule.c:1935:19: error: implicit declaration of function wins_nwstr; did you mean winsnstr? [-Werror=implicit-function-declaration]
 1935 |             rtn = wins_nwstr(self->win,wstr,n);
      |                   ^~~~~~~~~~
      |                   winsnstr
./Modules/_cursesmodule.c: In function _curses_unget_wch:
./Modules/_cursesmodule.c:4498:29: error: implicit declaration of function unget_wch; did you mean ungetch? [-Werror=implicit-function-declaration]
 4498 |     return PyCursesCheckERR(unget_wch(wch), "unget_wch");
      |                             ^~~~~~~~~
      |                             ungetch

@branfosj
Copy link
Member Author

Test report by @branfosj
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/68a6c89e2b1be644226f664d17aacac5 for a full test report.

@branfosj
Copy link
Member Author

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_BRANCH=5.0.x

@easybuilders easybuilders deleted a comment from boegelbot Apr 20, 2024
@easybuilders easybuilders deleted a comment from boegelbot Apr 20, 2024
@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=20407 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_20407 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4017

Test results coming soon (I hope)...

- notification for comment with ID 2067753702 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/d461d14c63741172eb233206afbe1285 for a full test report.

@bedroge
Copy link
Contributor

bedroge commented Apr 22, 2024

@boegelbot please test @ jsc-zen3
CORE_CNT=16

@boegelbot
Copy link
Collaborator

@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20407 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20407 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4018

Test results coming soon (I hope)...

- notification for comment with ID 2068939167 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 0 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/bc47410e7a119af59f4d18c8d5fba1c6 for a full test report.

@bartoldeman
Copy link
Contributor

this will need easybuilders/easybuild-easyblocks#3313 if sysroot is set as setup.py is gone

Set `'use_pip': True` to pass ensurepip.
@bartoldeman
Copy link
Contributor

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_ARGS="--include-easyblocks-from-pr 3313"

@bartoldeman
Copy link
Contributor

just set use_pip for testing with develop, but obv not needed with 5.0 any more.

@boegelbot
Copy link
Collaborator

@bartoldeman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20407 EB_ARGS="--include-easyblocks-from-pr 3313" EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20407 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4019

Test results coming soon (I hope)...

- notification for comment with ID 2070638949 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
Using easyblocks from PR(s) easybuilders/easybuild-easyblocks#3313
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/8bbb87d36b9547e522933b36bd298780 for a full test report.

@boegel boegel added this to the 4.x milestone Apr 23, 2024
@boegel
Copy link
Member

boegel commented Apr 23, 2024

@branfosj Can you mention what type of problem you hit without rebuilding ncurses with #20405, so people can easily find this?

@branfosj
Copy link
Member Author

@branfosj Can you mention what type of problem you hit without rebuilding ncurses with #20405, so people can easily find this?

Error message is in the collapsed block in #20407 (comment)

@branfosj
Copy link
Member Author

branfosj commented May 8, 2024

This PR shows what is required to build Python 3.12, but we do not want a second Python version against GCCcore/13.2.0 - so PR closed.

@branfosj branfosj closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants