Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use regular configure instead of wrapper script in easyblock for UCX plugins #3315

Merged
merged 2 commits into from
May 3, 2024

Conversation

bedroge
Copy link
Contributor

@bedroge bedroge commented Apr 28, 2024

Instead of calling contrib/configure-release, which is a wrapper that calls ./configure with some predefined options, the easyblock will now directly call configure with those options. This is the same approach as used in the PRs for the UCX easyconfigs: easybuilders/easybuild-easyconfigs#20428.

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel added this to the release after 4.9.1 milestone May 3, 2024
@boegel boegel added the riscv label May 3, 2024
@boegel
Copy link
Member

boegel commented May 3, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS UCX-CUDA-1.13.1-GCCcore-12.2.0-CUDA-12.0.0.eb
  • SUCCESS UCX-CUDA-1.15.0-GCCcore-13.2.0-CUDA-12.4.0.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
node3147.skitty.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 3.6.8
See https://gist.github.com/boegel/4dde393833b518ef800ee710f7ad6fe2 for a full test report.

@boegel boegel merged commit ee54421 into easybuilders:develop May 3, 2024
47 checks passed
@bedroge bedroge deleted the ucx_plugins_regular_configure branch May 3, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants