New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BuildKit for cache key memory usage patch #3505
Conversation
5b3a1c1
to
79452d7
Compare
e832ea3
to
7223e0b
Compare
Note: I ran the repro case for issue #2957 and did not encounter the error.
|
7223e0b
to
f7622e3
Compare
# ARG bazel_cache = "/root/.cache/bazel" | ||
# CACHE "$bazel_cache" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intended change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I'm not sure why these lines were leading to this failure: https://github.com/earthly/earthly/actions/runs/7023739400/job/19112169282
./e/bazel+build *failed* | --> expandargs readlink -f ./bazel-out
./e/bazel+build *failed* | [no output]
./e/bazel+build *failed* | ERROR examples/bazel/Earthfile line 33:4
./e/bazel+build *failed* | The command
./e/bazel+build *failed* | expandargs readlink -f ./bazel-out
./e/bazel+build *failed* | did not complete successfully. Exit code 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should just remove this example altogether. It's not very polished anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either or. The target seems to work without that CACHE
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah.. well the CACHE
was the most important point of the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I can look into it further.
I gave this some some more stress testing; by running:
along with
and another process periodically changing the contents of
and didn't see any solver issues, so I'm feeling less worried about this change :) |
@alexcb Cool. Thanks for doing that. I've also been running our Core tests against this branch with no apparent issues. https://github.com/earthly/earthly/actions/runs/7024593005?pr=3505 |
Updates BK for memory usage fixes in earthly/buildkit#33