Deprecate np asscalar #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
earthgecko
commented
Jan 20, 2023
earthgecko
commented
- Deprecated use of numpy asscalar as per Removed all the asscaler functions since they are deprecated in numpy linkedin/luminol#64 and EchoDel@7269a35
Changed the use of milliseconds to seconds and removed reference to milliseconds as it is not really used and when it is used it is used somewhat erroneously.
Whether to use the mean as per paulbourke method or the average as per LinkedIn method
- fix normalized as per 3adf692 - Deprecated use of numpy asscalar as per linkedin#64 and EchoDel@7269a35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.