Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Functions for listing hash providers and algorithms and specifying them when hashing #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamretter
Copy link
Member

@adamretter adamretter commented Nov 12, 2018

Requires - expath/crypto-java#5

Adds the functions:

  1. crypto:hash-providers() as xs:string*
  2. crypto:hash-algorithms($provider-name as xs:string) as xs:string*
  3. crypto:hash-algorithms() as map(xs:string, xs:string*)
  4. crypto:hash($data as item(), $algorithm as xs:string, $encoding as xs:string, $provider as xs:string)

@joewiz
Copy link
Member

joewiz commented Jul 17, 2019

This seems like a valuable PR. +1 to merging it or at least advancing discussion.

@joewiz
Copy link
Member

joewiz commented Jul 24, 2019

@claudius108 During this week's Community Call, the group took a look at this and thought it looked quite useful. What are your thoughts? Also, everyone is excited to have SHA256RSA, which @nsincaglia told us about—when you're able ;)

@claudius108
Copy link
Collaborator

SHA256RSA works already, I will push the changes after Nick Sincaglia will confirm also this.

As to the listing functions, in the new version of specification I added such functions, but more comprehensive. But you can keep these, if you want, it is up to you.

@nsincaglia
Copy link

nsincaglia commented Jul 24, 2019 via email

@eXist-db eXist-db deleted a comment from claudius108 Jul 24, 2019
@joewiz
Copy link
Member

joewiz commented Jul 24, 2019

Thanks, Claudius, could you point me to the URL with the version of the spec that contains the functions you mentioned?

@joewiz
Copy link
Member

joewiz commented Jul 24, 2019

I ask because maybe there's a way to bring this PR in line with the spec. Are there any implementations of your spec's version of the functions in question?

@adamretter
Copy link
Member Author

@claudius108 Where can we find the latest version of the spec please?

@claudius108
Copy link
Collaborator

@dizzzz
Copy link
Member

dizzzz commented Oct 26, 2019

what to do with this PR?

@line-o
Copy link
Member

line-o commented Jun 30, 2021

@adamretter can this be rebased?

@adamretter
Copy link
Member Author

@line-o Possibly... I can try... but it is from 2008. So I am not sure what has been incorporated in the mean-time! let me try...

@adamretter
Copy link
Member Author

Seems there is a corresponding PR to resolve here - expath/crypto-java#5

@adamretter
Copy link
Member Author

@line-o Okay, as requested I have rebased this. It requires that expath/crypto-java#5 is merged and a release of that published, but otherwise I believe this is ready to land.

@joewiz
Copy link
Member

joewiz commented Jun 30, 2021

@adamretter Do you know which (if any) spec these functions are intended to align with? I ask because as described in #41 I'd like to nail down the relationship between the spec(s) and the eXist implementation.

@joewiz
Copy link
Member

joewiz commented Jun 30, 2021

p.s. I think my merge of #45 caused a new conflict.

@adamretter
Copy link
Member Author

adamretter commented Jun 30, 2021

Do you know which (if any) spec these functions are intended to align with

@joewiz To be honest, I don't. This pull request is from 2018. It may be that I just recognised that these auxiliary functions may be useful, or that I followed a spec at that time. I am afraid I don't recall...

@adamretter
Copy link
Member Author

p.s. I think my merge of #45 caused a new conflict.

@joewiz Ah ha. No worries, I have resolved and rebased that now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants