Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting the namespace on the result of sql:execute #5186

Open
wants to merge 1 commit into
base: develop-6.x.x
Choose a base branch
from

Conversation

nverwer
Copy link

@nverwer nverwer commented Jan 10, 2024

Description:

This change introduces two new signatures for the sql:execute function:

sql:execute($connection-handle as xs:long, $sql-statement as xs:string, $make-node-from-column-name as xs:boolean, $ns-prefix as xs:string, $ns-uri as xs:string) as element()?
sql:execute($connection-handle as xs:long, $statement-handle as xs:long, $parameters as element()?, $make-node-from-column-name as xs:boolean, $ns-prefix as xs:string, $ns-uri as xs:string) as element()?

These functions allow setting a namespace on the output of sql:execute that is different from the default.
This may be useful in contexts where namespace processing is unwanted, or different namespaces for different result sets are wanted.

Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

71.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@line-o line-o requested a review from a team January 10, 2024 12:33
@line-o line-o added needs documentation Signals issues or PRs that will require an update to the documentation repo enhancement new features, suggestions, etc. needs Junit test Java test required to reproduce needs develop port needs XQSuite test XQSuite test required to reproduce and removed needs Junit test Java test required to reproduce labels Jan 10, 2024
@line-o
Copy link
Member

line-o commented Jan 10, 2024

Thank you @nverwer for your contribution. I would like to see the reorganisation of imports to be in a separate commit and a few tests (either jUnit or XQSuite) as well as a tiny bit of documentation explaining how to use that feature.
Also the commit message needs to be prepended with [enhancement].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new features, suggestions, etc. needs develop port needs documentation Signals issues or PRs that will require an update to the documentation repo needs XQSuite test XQSuite test required to reproduce
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants