Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple ward reductions on one network #2282

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

p1p31
Copy link

@p1p31 p1p31 commented May 3, 2024

Problem

If multiple ward equivalent calculations are done on the same network (e.g. clustering nodes), currently an error appears when a ward equivalent unit should be placed on a bus where already a ward equivalent unit stands.

Fix

The changes inside the code picks only the newly created units.

Open Problems/Assumptions

Assuming the power on the load of the previous added ward element is unequal to zero. Maybe this could be a harsh assumption, maybe there is a better proposal recognizing the previously added ward elements. I could imagine just picking by bus number the last element in the dataframe, but this feels unsafe too.

Ensure changing correct ward equivalents if ward equivalents were already added to that bus
@SteffenMeinecke
Copy link
Member

Dear @p1p31,
I think you address a point in @ZhengLiu1119's code that was actually not programmed cleanly enough to avoid confusion in the computational run. This PR probably reduces the risk of confusion, but in principle shows the same weakness.
As long as there is no better implementation, it is probably best to always delete all wards/extended wards beforehand, which can lead to confusion in the code when grid equivalents are generated again. Utilising the group functionality can help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants