fix which repairs set_line_geodata if the net doesn't have geodata fo… #2123
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2123 +/- ##
============================================
+ Coverage 62.30% 79.44% +17.14%
============================================
Files 255 255
Lines 28062 27951 -111
============================================
+ Hits 17483 22205 +4722
+ Misses 10579 5746 -4833 ☔ View full report in Codecov by Sentry. |
|
please add a changelog mention |
ignore_zero_length lead to assignment error in set_line_geodata_from_bus_geodata.
Feature/repaired set line geodata
SteffenMeinecke
dismissed
rbolgaryn’s stale review
the changelog has been adapted
|
tutorial tests are failing:
Can it have anything to do with the changes in this PR? |
…eature/repaired_set_line_geodata AND plotting_toolbox revision and testing
|
@vogt31337 @KS-HTK I fixed this PR. Can you please merge? |
| @@ -498,7 +498,8 @@ def _get_coords_from_geojson(gj_str): | |||
| return ast.literal_eval(m) | |||
| return None | |||
|
|
|||
| if use_bus_geodata is False and line_geodata is None and ("geo" not in net.line.columns or net.line.geo.empty): | |||
| if use_bus_geodata is False and line_geodata is None and ( | |||
| "geo" not in net.line.columns or net.line.geo.empty): | |||
There was a problem hiding this comment.
net.line.geo.empty is only true if net.line.empty is true, since it the geo column contains every row of the net.line table even if no value is given. A check if no geo values are present should be done using net.line.geo.dropna().empty or similarly (see also plotting_toolbox.py:210 it uses net.bus.geo.isnull().all()).
Hi,
currently if you have a somewhat broken grid, which doesn't have geodata for all lines, you can take this function and "create" line data from the connecting nodes. But if not all nodes are having geodata, this function breaks.
This fix will now calculate a mean replacement coordinate (if the user wants it) and sets this replacement into all nodes without geodata. Therefore the grid will have many lines connecting to the center, but It's better than nothing...
BR