-
Notifications
You must be signed in to change notification settings - Fork 466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a module which can iterate the workdir and find the target files … #2047
base: develop
Are you sure you want to change the base?
Conversation
…without duplicates,a method different from cim2pp.ipynb in tutorials.
@@ -1,21 +1,71 @@ | |||
# import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this commented code can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well,since this change is not so necessary , I prefer keep this "commented code" to keep up with the tutorial of "cim2pp.ipynb" , this code is more experimental rather than the original cods. and its's just tested with vscode in linux now, I didn't test it in NT system. By the way, I had tried to use the relative path, the "/" in posix and "" in nt is frustrated, that is another reason I turn to the iterable function. I'd like to comment here like that:" this fucntion is a optional method, the commented code above is more easy and simple for guys focus on prime concept. " , could this be done?
Dear @ForkCarpenter , can you please explain in the comments what the new function is doing? It is not very easy to understand how the function works exactly. Also, please modify the CHANGELOG.rst file. Best regards, |
Dear Sir @rbolgaryn : The second subtle bug is at the end of plotting , the picture doesn't show on automatically ,the "matplotlib.pyplot" show() function seems necessary . The other reason I keep working on this change is that in the future front-end programming like pyQT styled interactive dialog box. it's more useful for the Iterable "find_files" function as I thiink. And sorry for that I'm totally amateur on programming, your latest issue in pytest was a good example for me, thank you very much, I'd like to comment in more details on the code to make it understood More easily , include the CHANGELOG.rst file. Best wishes |
…n,include the CHANGELOG.rst
38f97a5
to
d563b63
Compare
Dear @ForkCarpenter, We had looked at your request. A few points:
Please elaborate more on these points and move your test from test_from_cim to another file, otherwise we must decline your pull request. |
…without duplicates,a method different from cim2pp.ipynb in tutorials.