Don't hardcode URL scheme, domain, port in HTML #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serving hardcoded HTML base URL scheme, domain and port from the server's point of view to the client breaks when proxying to use publicly facing settings different from the one configured internally in the webserver. The context path is still used, and needs to be the same internally as well as externally. This enables for example proxied HTTPS support, while allowing export services to make requests which do not require roundtrips outside of the server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serving hardcoded HTML base URL scheme, domain and port from the server's
point of view to the client breaks when proxying to use publicly facing
settings different from the one configured internally in the webserver.
The context path is still used, and needs to be the same internally as
well as externally.
This enables for example proxied HTTPS support, while allowing export services
to make requests which do not require roundtrips outside of the server.