This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
Pod cleanup, KVO crash fix, progress bar fix #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexhillc
commented
Apr 28, 2017
•
alexhillc
commented
- Cleanup Pod files by adding the Pods directory to .gitignore (a 'pod install' will be needed after cloning, but this reduces clutter in the repo generated by the Sample app)
- Retain reference to navigation bar to fix temperamental KVO crash on dealloc.
- Clear progress view in viewDidDisappear:, dealloc as well as viewWillDisappear: - just in case there is a situation in which we receive delegate progress callbacks.
- Add parens to statement causing warning in Xcode 8.3
install' will be needed after cloning, but this reduces space
generated by the Sample app)
- Retain reference to navigation bar to fix temperamental KVO crash on
dealloc.
- Clear progress view in viewDidDisappear: as well as viewWillDisappear:
- just in case there is a situation in which we receive delegate
progress callbacks.
- Final removal of progressView in dealloc if need be. May be redundant, but it's a valid case.
alexhillc
force-pushed
the
master
branch
2 times, most recently
from
ba2aca6
to
d12791f
Compare
|
I think this pull request will address the issue in progress bar bug when pushing the web view controller, as well as the bug in the activity indicator when the controller is dismissed while loading. Good job @alexhillc 👍 |
APPS-1766 Ignore plugin change error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.