Check that the C++11 future feature is supported for kaleid0sc0pe #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaromil
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Hi Brendan! many thanks! if you want to trigger a fix release with semantic versioning next time please consider using fix: as first 4 chars of the first line in commit description, this will trigger CI automations and tag a new release right after merging your PR. This time is fine, I'll merge other fixes and trigger it myself.
The mingw cross compiler for windows can be built with either a posix thread model or a win32 thread model. The win32 thread model does not fully support future. So we detect if future compilation works and disable multithreading if not. Fixes issue dyne#178
jaromil
force-pushed
the
validate-future
branch
from
f425d7e
to
8e141db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mingw cross compiler for windows can be built with either a posix thread model or a win32 thread model. The win32 thread model does not fully support future and builds fail. So we detect if future compilation works and disable multithreading if not.
Fixes issue #178