Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

fix(metadataRetriever): get tabs with tooling api #749

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Dec 12, 2022

This fixes #737 and #738

Summary of changes

It looks like the Tooling API returns more TabDefinitions records (and therefore more accurate) than the SOAP API.
These are the ones which are mentioned to be missing in #737.
They are now included in the sfpowerkit:source:profile:retrieval and retained in the sfpowerkit:source:profile:reconcile command.

Here is the diff from the output of running

sfdx force:data:soql:query -q "SELECT Name FROM TabDefinition"
vs.
sfdx force:data:soql:query -q "SELECT Name FROM TabDefinition" --usetoolingapi

--- tab-definitions-soap.csv
+++ tab-definitions-tooling.csv
@@ -7,11 +7,17 @@
 standard-AuthorizationFormConsent
 standard-AuthorizationFormDataUse
 standard-AuthorizationFormText
+standard-Award
 standard-BackgroundOperation
+standard-Budget
+standard-BudgetAllocation
 standard-BusinessBrand
 standard-Campaign
 standard-Case
 standard-CmsAuthorHome
+standard-CmsChannel
+standard-CmsExperiences
+standard-CmsWorkspaces
 standard-CommSubscription
 standard-CommSubscriptionChannelType
 standard-CommSubscriptionConsent
@@ -20,7 +26,10 @@
 standard-ContactPointConsent
 standard-ContactPointTypeConsent
 standard-ContactRequest
+standard-ContentDocumentListViewMapping
 standard-ContentNote
+standard-ContentSearch
+standard-ContentSubscriptions
 standard-Contract
 standard-ContractLineItem
 standard-Customer
@@ -42,6 +51,8 @@
 standard-FlowOrchestrationWorkItem
 standard-Forecasting3
 standard-Idea
+standard-IdeaTheme
+standard-IdentityDocument
 standard-Image
 standard-Individual
 standard-Knowledge
@@ -54,6 +65,7 @@
 standard-LocationTrustMeasure
 standard-Macro
 standard-MobileHome
+standard-OmnichannelInventory
 standard-OnlineSalesHome
 standard-Opportunity
 standard-Order
@@ -68,7 +80,9 @@
 standard-ScheduleAppointments
 standard-Scorecard
 standard-Seller
+standard-ServiceAppointmentGroup
 standard-ServiceContract
+standard-ServiceTerritoryRelationship
 standard-SocialPersona
 standard-SocialPost
 standard-Solution
@@ -76,6 +90,11 @@
 standard-Task
 standard-Today
 standard-UserProvisioningRequest
+standard-VoiceCall
 standard-WorkOrder
+standard-WorkProcedure
+standard-WorkProcedureStep
+standard-WorkTypeExtension
+standard-Workspace
 standard-home
 standard-report

Checklist

  • Adhere to Contribution Guidelines yes
  • Updates to documentation at DX@Scale Guide required? no
  • Tested changes? yes, tested the sfpowerkit:source:profile:retrieval and sfpowerkit:source:profile:reconcile commands

Manuel Moya added 2 commits December 12, 2022 14:50
@ghost
Copy link
Author

ghost commented Dec 13, 2022

@ethan-sargent I took a quick look to the smoke-tests execution and saw the issue is related to the DevHub authentication. Could you help with that?

@ethan-sargent
Copy link

@azlam-abdulsalam can you please grant access so I can view the pipeline secrets?
Seems the SFDX AuthURL is missing.

@ethan-sargent
Copy link

@mmoya-sage looks good to me! Will merge once I can resolve the CI issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant