fixed an array bounds error with the CrewUnitGroup example class that…

… kept one cargo seat empty sometimes
dwringer · Oct 29, 2016 · 37f7c32 · 37f7c32
1 parent 9305bc9
commit 37f7c32
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/ClassDemo.Tanoa/classdef/CrewUnitGroup.hpp b/ClassDemo.Tanoa/classdef/CrewUnitGroup.hpp
@@ -119,7 +119,7 @@ DEFMETHOD("CrewUnitGroup", "board_instant") ["_self"] DO {
         };
 	for "_i" from 0 to (_vlen - 1) do {
 		if ((count _cargoSeats) > _i) then {
-  			for "_j" from 0 to (_cargoSeats select _i) do {
+			for "_j" from 0 to ((_cargoSeats select _i) - 1) do {
 				if ((count _gunners) > 0) then {
 					_vehicle = _vehicles select _i;
 					_cargo = _gunners select 0;
@@ -131,4 +131,4 @@ DEFMETHOD("CrewUnitGroup", "board_instant") ["_self"] DO {
 		        };
 		};
 	};
-} ENDMETHOD;
+} ENDMETHOD;
diff --git a/classdef/CrewUnitGroup.hpp b/classdef/CrewUnitGroup.hpp
@@ -119,7 +119,7 @@ DEFMETHOD("CrewUnitGroup", "board_instant") ["_self"] DO {
         };
 	for "_i" from 0 to (_vlen - 1) do {
 		if ((count _cargoSeats) > _i) then {
-  			for "_j" from 0 to (_cargoSeats select _i) do {
+			for "_j" from 0 to ((_cargoSeats select _i) - 1) do {
 				if ((count _gunners) > 0) then {
 					_vehicle = _vehicles select _i;
 					_cargo = _gunners select 0;
@@ -131,4 +131,4 @@ DEFMETHOD("CrewUnitGroup", "board_instant") ["_self"] DO {
 		        };
 		};
 	};
-} ENDMETHOD;
+} ENDMETHOD;