Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Scanner interface as an abstraction for Clamd struct #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

legosx
Copy link

@legosx legosx commented Oct 31, 2019

For testing purposes I would like to have an interface as an abstraction from Clamd.

Pull Request is just adding the interface without changing any logic.

The name Scanner can be discussed but I think that it represents the methods inside of the interface.

@Freeaqingme
Copy link
Contributor

Do we really need a single interface containing all methods? Would it not be better to split it up in multiple smaller logical chunks?

Wrt to your return argument. How does it pertain to the guideline of 'accept interfaces, return structs'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants