Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch routes callback to customize which routes are enabled #105

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pedrosancao
Copy link

@pedrosancao pedrosancao commented Jul 3, 2019

The original routes always enabled all routes, when a callback is provided it causes error because it calls $callback->group().

@dusterio
Copy link
Owner

dusterio commented Jul 3, 2019

Is this backward compatible?

@pedrosancao
Copy link
Author

pedrosancao commented Jul 3, 2019

I've tested only with 5.8.

I am assuming backward compatible until 5.5 as per updated readme from @MartinParrish fork.
As the updated code use illuminate facade Route, and it is also available on 5.5 it should not have any issue.

Same facade is available in 5.3 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants