Fix brackets highlighting in "solarizedl" #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I now see there's already a PR open for this: #341. Oh well, maybe this will have better luck getting merged? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #311.
This makes the value
theme-flavor-inversein "solarizedl" actually an inverse oftheme-flavor. All the dark themes have them differing, but in the light themes they are currently the same. The other light themes don't encounter the issue above, because they use a custom background color for highlighted brackets, but maybe they should be fixed accordingly too. In that case we might also want to adjust their background colors, so I leave that out of this fix.I also checked that it's safe to change
theme-flavor-inverse. It's only used in the CSS forspan.CodeMirror-matchingbracket(the subject of the issue above) andspan.CodeMirror-nonmatchingbracket(the red highlighting for an unmatched bracket); the latter becomes black on red, which I think is okay too.