chore: replace scripts with xtask pattern #1097

simonbuchan · 2023-10-05T07:35:25Z

Description:

Migrates scripts to use xtask pattern.

Related issue (if exists):

See discussion in #1096

changeset-bot · 2023-10-05T07:35:28Z

⚠️ No Changeset found

Latest commit: b348e8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2023-10-05T07:49:39Z

Thank you for the PR!
Commit: b348e8d

Files to check

These are files which is affected by the current PR, but not reflected. If there's no file below this message, please ignore this message.

You can run cargo xtask auto-unignore for typescript files, and cargo xtask test-checker for *.stats.rust-debug files.

crates/stc_ts_type_checker/tests/conformance.pass.txt

simonbuchan · 2023-10-10T09:45:30Z

Not dead yet! I got distracted trying to figure out why mimalloc-rust (used by swc_node_base on non-linux platforms) was being all crashy, but that should be a separate PR if I do figure it out.

This is pretty close for what's implemented: the enabled tests for stc_ts_{file_analyzer,type_checker}.

The main thing left I know about is that cargo xtask auto-unignore is generating a bunch of .*.tsc-errors.json files outside of tests/tsc, so they aren't getting cleaned up. I have no idea what I'm doing differently to the shell script here, unfortunately.

kdy1 · 2023-10-10T12:48:16Z

I can take a look when I have time

simonbuchan · 2023-10-10T23:16:14Z

Thanks, I'll keep at it anyway. I'm pretty sure it's effectively the same command line (modulo order), so it's most likely something to do with current directory, variables, me using volta or the like. I just can't track down why that would result in what I'm seeing.

simonbuchan · 2023-11-01T07:23:09Z

Ugh. Sorry for disappearing for like (checks) THREE WEEKS. Geez. I did poke at this a few times, but didn't figure out what could have been causing the last issue where cargo xtask auto-unignore was generating a bunch of .stc-stderr files (not .tsc-errors.json like I thought!)

Turned out to just be that auto-unignore.sh didn't set UPDATE=1. I have no idea why that makes a difference, there doesn't seem to be any reference to that variable in Rust source at least? Rather annoying that it was that simple.

And as I've said before, I'm happy to make any changes or additions you would prefer.

kdy1

I think we can remove the replaced scripts

kdy1 · 2023-11-07T01:30:04Z

xtask/src/type_checker.rs

+    tests.sort();
+
+    use std::io::Write;
+    let mut file = std::fs::File::create("crates/stc_ts_type_checker/tests/conformance.pass.txt")?;


Should we use a buffer here?

And use the xtasks in CI.

simonbuchan · 2023-11-14T08:48:00Z

Ok, I removed all the now replaced .sh files: there's still a few (like profile.sh) that should be pretty easy to replace now.

This updates the CI's use of the old scripts.. 🤞

For reference, the cargo xtask test-analyzer works fine on windows, but test-checker fails with:

...
error: test failed, to rerun pass `-p stc_ts_type_checker --test tsc`
Error: test conformance failed: exit code: 101
error: process didn't exit successfully: `target\debug\xtask.exe test-checker` (exit code: 1)

which I think is the mimalloc issue I referred to above? When I get a little bandwidth I'll see if I can track down what's going on there...

simonbuchan · 2023-11-14T08:53:05Z

Hmm, cargo xtask test-checker did also panic on CI in "PR Maintenance / All passing tests should be enabled (pull_request) " ... might be something going on there? Not much detail.

It's currently expected to fail. This also doesn't skip .tsx tests (free passing tests!) and prints dot-style test output progress.

simonbuchan · 2023-11-14T10:33:36Z

Ah, it's expected to fail for now, but also it fails with mimalloc heap corruption on windows.

I fixed it not updating conformance.pass.txt if it fails, and also tossed in a dot progress reporter and stopped it filtering out .tsx test passes. Let me know if either of those seem bad to you!

kdy1 · 2023-11-14T13:43:44Z

It's fine, but CI failed.

simonbuchan · 2023-11-14T18:57:28Z

Yeah. Tested on WSL Ubuntu and it ran through there. Any idea how to get the panic message at least?

…

On Wed, 15 Nov 2023, 2:43 am kdy1, ***@***.***> wrote: It's fine, but CI failed. — Reply to this email directly, view it on GitHub <#1097 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAOBLI3MRDL24G6RHZZU6SDYENYRZAVCNFSM6AAAAAA5TZO5Q6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQGIZDSOJWGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

simonbuchan changed the title ~~Draft: chore: replace scripts with xtask pattern~~ WIP: chore: replace scripts with xtask pattern Oct 5, 2023

kdy1 marked this pull request as draft October 5, 2023 08:10

simonbuchan added 6 commits November 1, 2023 20:14

Add xtask pattern as alternative to shell script.

5ee348b

Migrate other scripts mentioned in contributing docs.

8467959

Various cleanup-ey-ness, implement log max filter level.

90d5dab

Fix some auto-unignore issues.

5cae691

Don't set UPDATE=1 on xtask auto-unignore

6c9103d

Update Cargo.lock

83a37a3

simonbuchan force-pushed the xtask branch from 8ec1cd7 to 83a37a3 Compare November 1, 2023 07:17

simonbuchan changed the title ~~WIP: chore: replace scripts with xtask pattern~~ chore: replace scripts with xtask pattern Nov 1, 2023

Add xtask to cspell.json

614cbb7

simonbuchan marked this pull request as ready for review November 1, 2023 07:30

sunrabbit123 requested a review from kdy1 November 7, 2023 01:20

kdy1 requested changes Nov 7, 2023

View reviewed changes

kdy1 reviewed Nov 7, 2023

View reviewed changes

simonbuchan added 2 commits November 14, 2023 21:34

Remove scripts now implemented by xtasks.

25e748d

And use the xtasks in CI.

Cleanup writing test-checker output.

767e1a1

xtask test-checker should always update output.

b348e8d

It's currently expected to fail. This also doesn't skip .tsx tests (free passing tests!) and prints dot-style test output progress.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: replace scripts with xtask pattern #1097

chore: replace scripts with xtask pattern #1097

simonbuchan commented Oct 5, 2023

changeset-bot bot commented Oct 5, 2023 •

edited

github-actions bot commented Oct 5, 2023 •

edited

simonbuchan commented Oct 10, 2023

kdy1 commented Oct 10, 2023

simonbuchan commented Oct 10, 2023

simonbuchan commented Nov 1, 2023 •

edited

kdy1 left a comment

kdy1 Nov 7, 2023 •

edited

simonbuchan commented Nov 14, 2023

simonbuchan commented Nov 14, 2023

simonbuchan commented Nov 14, 2023

kdy1 commented Nov 14, 2023

simonbuchan commented Nov 14, 2023 via email

chore: replace scripts with xtask pattern #1097

Are you sure you want to change the base?

chore: replace scripts with xtask pattern #1097

Conversation

simonbuchan commented Oct 5, 2023

changeset-bot bot commented Oct 5, 2023 • edited

⚠️ No Changeset found

github-actions bot commented Oct 5, 2023 • edited

Files to check

simonbuchan commented Oct 10, 2023

kdy1 commented Oct 10, 2023

simonbuchan commented Oct 10, 2023

simonbuchan commented Nov 1, 2023 • edited

kdy1 left a comment

Choose a reason for hiding this comment

kdy1 Nov 7, 2023 • edited

Choose a reason for hiding this comment

simonbuchan commented Nov 14, 2023

simonbuchan commented Nov 14, 2023

simonbuchan commented Nov 14, 2023

kdy1 commented Nov 14, 2023

simonbuchan commented Nov 14, 2023 via email

changeset-bot bot commented Oct 5, 2023 •

edited

github-actions bot commented Oct 5, 2023 •

edited

simonbuchan commented Nov 1, 2023 •

edited

kdy1 Nov 7, 2023 •

edited