Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cubature Kalman Filter #948

Merged
merged 1 commit into from
May 15, 2024
Merged

Cubature Kalman Filter #948

merged 1 commit into from
May 15, 2024

Conversation

jmbarr
Copy link
Contributor

@jmbarr jmbarr commented Feb 1, 2024

Provides a cubature Kalman predictor and updater. (Credit should go to Bethany? I think.)

Side issue is that there's some odd behaviour at certain configurations. I'll provide a gist to highlight that.

@jmbarr jmbarr requested a review from a team as a code owner February 1, 2024 21:27
@jmbarr jmbarr requested review from sdhiscocks and hpritchett-dstl and removed request for a team February 1, 2024 21:27
Copy link
Member

@sdhiscocks sdhiscocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Just some minor formatting changes, undo changes that'll break NumPy 2.0 compatibility, and new additional prior for Prediction type.

stonesoup/functions/__init__.py Outdated Show resolved Hide resolved
stonesoup/functions/__init__.py Outdated Show resolved Hide resolved
stonesoup/functions/__init__.py Outdated Show resolved Hide resolved
stonesoup/functions/__init__.py Outdated Show resolved Hide resolved
stonesoup/functions/__init__.py Outdated Show resolved Hide resolved
stonesoup/functions/__init__.py Outdated Show resolved Hide resolved
stonesoup/functions/__init__.py Outdated Show resolved Hide resolved
stonesoup/predictor/kalman.py Outdated Show resolved Hide resolved
stonesoup/predictor/kalman.py Outdated Show resolved Hide resolved
stonesoup/predictor/kalman.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 93.64%. Comparing base (0089d29) to head (46277d3).

Files Patch % Lines
stonesoup/functions/__init__.py 89.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   93.61%   93.64%   +0.02%     
==========================================
  Files         203      203              
  Lines       13051    13103      +52     
  Branches     2666     2673       +7     
==========================================
+ Hits        12218    12270      +52     
+ Misses        588      587       -1     
- Partials      245      246       +1     
Flag Coverage Δ
integration 65.95% <35.93%> (-0.10%) ⬇️
unittests 89.26% <93.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbarr
Copy link
Contributor Author

jmbarr commented Feb 19, 2024

Looks good 👍 Just some minor formatting changes, undo changes that'll break NumPy 2.0 compatibility, and new additional prior for Prediction type.

Don't think I did any of these formatting changes and can't explain how they got in. Is there an 'undo' button?

Co-authored-by: jordi <jmbarr@dstl.gov.uk>
@sdhiscocks sdhiscocks merged commit 072fb92 into main May 15, 2024
10 checks passed
@sdhiscocks sdhiscocks deleted the cubatureKalman2 branch May 15, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants