Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses STL helper types. #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Uses STL helper types. #60

wants to merge 1 commit into from

Conversation

jiawen
Copy link
Collaborator

@jiawen jiawen commented Dec 10, 2021

No description provided.

@jiawen jiawen requested a review from dsharlet December 10, 2021 16:50
@jiawen
Copy link
Collaborator Author

jiawen commented Dec 10, 2021

Oops, I forgot the target is C++14, not C++17.

@dsharlet
Copy link
Owner

I think unless there is some other bigger simplification we can make by targeting C++17 instead of C++14, it's not worth changing just for this? Personally I don't mind the slightly more verbose helpers here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsharlet dsharlet Awaiting requested review from dsharlet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiawen @dsharlet