Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image_Augmentation Added #112

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ShambhaviCodes
Copy link

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@AnirudhDagar
Copy link
Member

@ShambhaviCodes Is this WIP? I can see a lot of things missing from here

@ShambhaviCodes
Copy link
Author

Okay yes, I didn't include a training model.
Will add it.

@ShambhaviCodes
Copy link
Author

Anymore changes required?

@CaptainDredge
Copy link
Member

@ShambhaviCodes We've to exactly mirror all the sections from here I can see you've condensed many sections into one. If possible try to use the same image of cat used in d2l. The model and the training dataset also differ but I think that maybe acceptable.
/cc @AnirudhDagar

@ShambhaviCodes
Copy link
Author

Please confirm about the model and dataset. I plan to make the changes this weekend!

@CaptainDredge
Copy link
Member

Hi @ShambhaviCodes sorry for the staleness of the project. Maintainers are busy nowadays. I can merge your PR if you can deliver the following things:

-[ ] Mirror the sections of d2l original repo as closely as possible without merging it into one. You can find utilities like show_images in the d2l package in the repo. If you need any other utility feel free to implement one.
-[ ] Download and use the image of turtle from original repo
-[ ] If Cifar-10 dataset is possible try to run the model on it. If not then MNIST is fine given the limited resources we have

PS: I can understand Multi-GPU training will not be possible at all

@ShambhaviCodes
Copy link
Author

Hello @CaptainDredge
Will make the changes and push over this weekend.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants