Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for split_vector() from utils.R. #310

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hxxr
Copy link

@hxxr hxxr commented Dec 13, 2019

No description provided.

@codecov
Copy link

codecov bot commented Dec 13, 2019

Codecov Report

Merging #310 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   78.98%   78.93%   -0.05%     
==========================================
  Files          39       38       -1     
  Lines        2398     2293     -105     
==========================================
- Hits         1894     1810      -84     
+ Misses        504      483      -21
Impacted Files Coverage Δ
src/HashCorpus.cpp 66.21% <0%> (-2.92%) ⬇️
R/model_GloVe.R 58.11% <0%> (-1.39%) ⬇️
src/GloveFitter.cpp 70.37% <0%> (-1.3%) ⬇️
R/tcm.R 85.89% <0%> (-1.01%) ⬇️
R/iterators.R 77.7% <0%> (-0.69%) ⬇️
R/model_LSA.R 73.68% <0%> (-0.68%) ⬇️
R/vectorizers.R 90.47% <0%> (-0.64%) ⬇️
src/VocabCorpus.cpp 91.83% <0%> (-0.62%) ⬇️
src/utils.cpp 55.93% <0%> (-0.52%) ⬇️
R/vocabulary.R 85.4% <0%> (-0.52%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f673a93...f9bbeb4. Read the comment docs.

@dselivanov
Copy link
Owner

@hxxr thanks for your contribution - PR with test coverage are especially appreciated. Let me know when this will be ready for review.

@hxxr hxxr marked this pull request as ready for review December 22, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants