xWebSite: Choose cert with greatest validity

[ThomasHughesIV]

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

• [x ] Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• [x ] New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[ThomasHughesIV]

Wow, is pester updated or something? I cannot see how this failed so badly in build when changing one line of code with Where-Object statements

[johlju]

Yes, Pester 5 was released so we need to pin Pester to 4.10.1 here

https://github.com/dsccommunity/xWebAdministration/blob/c7c81dcdca4102b5e06f0ffed16b35d1b7f6c07b/RequiredModules.psd1#L11

[johlju]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ThomasHughesIV)

a discussion (no related file):
Can you please add a unit test (or change an existing) so that the correct certificate is chosen?

https://github.com/dsccommunity/xWebAdministration/blob/c7c81dcdca4102b5e06f0ffed16b35d1b7f6c07b/tests/Unit/MSFT_xWebsite.Tests.ps1#L2273

---

[ThomasHughesIV]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ThomasHughesIV)

a discussion (no related file):
Can you please add a unit test (or change an existing) so that the correct certificate is chosen?

https://github.com/dsccommunity/xWebAdministration/blob/c7c81dcdca4102b5e06f0ffed16b35d1b7f6c07b/tests/Unit/MSFT_xWebsite.Tests.ps1#L2273

Yes, I can do that. I think. I'm still new to all of this.

[johlju]

Ping me if I can help in some way.

[ThomasHughesIV]

Ping me if I can help in some way.

I appreciate that, thank you. This might take some time, as I'm trying to determine how certs are generated by pester (and learn pester at the same time)

[johlju]

In a unit test you mock cmdlets/functions with Pester. So you mock what a cmdlet should return. So if you have a function let say Get-Certificate you mock it to return the certificate (the necessary object with properties).

Example below. Not sure this is the correct way to mock the certificate in this case but gives you an idea.

Mock -CommandName Get-Certificate -MockWith {
    return [PSCustomObject] @{
        SubjectName = ‘cert1’
        Property2 = ‘value2’
    }
}

[johlju]

We have renamed the resource, removing 'x', so please rebase this PR.