New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlInstall: New resource #1912

Draft

johlju wants to merge 16 commits into dsccommunity:main from johlju:f/install-class-based-resource

Member

johlju commented Apr 15, 2023 •

edited

Pull Request (PR) description

SqlServerDsc
- New class-based resource:
  - SqlInstall - Handles the Microsoft SQL Server setup action Install.

This Pull Request (PR) fixes the following issues

Partly helps with #1781 .

Task list

Added an entry to the change log under the Unreleased section of the
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
Resource documentation updated in the resource's README.md.
Resource parameter descriptions updated in schema.mof.
Comment-based help updated, including parameter descriptions.
Localization strings updated.
Examples updated.
Unit tests updated. See DSC Community Testing Guidelines.
Integration tests updated (where possible). See DSC Community Testing Guidelines.
Code changes adheres to DSC Community Style Guidelines.

This change is

github-advanced-security bot found potential problems

View reviewed changes

source/Classes/020.SqlInstall.ps1

+                      This example shows how to call the resource using Invoke-DscResource.
+              #>
+              [DscResource(RunAsCredential = 'Optional')]

Check failure

Code scanning / PSScriptAnalyzer

The DSC resource 'SqlInstall' must have at least one key property (using the syntax [DscProperty(Key)].) Error

The DSC resource 'SqlInstall' must have at least one key property (using the syntax [DscProperty(Key)].)

source/Classes/020.SqlInstall.ps1

+                      This example shows how to call the resource using Invoke-DscResource.
+              #>
+              [DscResource(RunAsCredential = 'Optional')]

Check failure

Code scanning / PSScriptAnalyzer

The DSC resource 'SqlInstall' is missing a Test method that returns [bool] and accepts no parameters. Error

The DSC resource 'SqlInstall' is missing a Test method that returns [bool] and accepts no parameters.

source/Classes/020.SqlInstall.ps1

+                          ServerName   = $this.ServerName
+                      }
+                      $serverObject = $this.GetServerObject()

Check warning

Code scanning / PSScriptAnalyzer

The variable 'currentInstalledServiceNames' is assigned but never used. Warning

The variable 'currentInstalledServiceNames' is assigned but never used.

source/Classes/020.SqlInstall.ps1

+                      a value.
+                  #>
+                  hidden [void] AssertProperties([System.Collections.Hashtable] $properties)
+                  {

Check warning

Code scanning / PSScriptAnalyzer

Empty End block. Warning

Empty End block.

johlju added the waiting for code fix label

codecov bot commented Apr 15, 2023 •

edited

Codecov Report

Attention: 427 lines in your changes are missing coverage. Please review.

Comparison is base (a9f8f26) 94% compared to head (f568f52) 89%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@          Coverage Diff          @@
##           main   #1912    +/-   ##
=====================================
- Coverage    94%     89%    -5%     
=====================================
  Files        93     119    +26     
  Lines      7844    8285   +441     
=====================================
+ Hits       7424    7438    +14     
- Misses      420     847   +427

Flag	Coverage Δ
unit	`89% <3%> (-5%)`	⬇️

Files	Coverage Δ
source/Classes/011.SqlResourceBase.ps1	`83% <ø> (ø)`
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1	`98% <ø> (ø)`
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1	`96% <ø> (ø)`
source/Private/ConvertFrom-ServiceStartMode.ps1	`100% <100%> (ø)`
source/Private/Get-InstanceId.ps1	`100% <100%> (ø)`
source/Private/Get-RegistryPropertyValue.ps1	`100% <100%> (ø)`
...blic/Test-SqlDscIsIntegrationServicesInstalled.ps1	`0% <0%> (ø)`
...ublic/Test-SqlDscIsMasterDataServicesInstalled.ps1	`0% <0%> (ø)`
...lDscIsBackwardCompatibilityComponentsInstalled.ps1	`0% <0%> (ø)`
...ource/Public/Test-SqlDscIsBooksOnlineInstalled.ps1	`0% <0%> (ø)`
... and 19 more

johlju force-pushed the f/install-class-based-resource branch from 419de3c to 8088506 Compare

April 16, 2023 09:41

github-actions bot commented May 16, 2023

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

github-actions bot added the abandoned label

Member Author

johlju commented May 23, 2023

This is a big undertaking creating this resource and at the same time trying to re-invent the logic to be (hopefully) more efficient. But hopefully that will make it quicker to create the other setup action resources.

github-actions bot removed the abandoned label

github-actions bot commented Jun 7, 2023

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

github-actions bot added abandoned and removed abandoned labels

johlju force-pushed the f/install-class-based-resource branch from 66de733 to e0af130 Compare

June 18, 2023 09:36

github-advanced-security bot found potential problems

View reviewed changes

source/Classes/020.SqlInstall.ps1

+                      #>
+                      $currentInstalledServiceNames = (Get-SqlDscManagedComputerService).Name
+                      $serverObject = $this.GetServerObject()

Check warning

Code scanning / PSScriptAnalyzer

The variable 'serverObject' is assigned but never used. Warning

The variable 'serverObject' is assigned but never used.

johlju force-pushed the f/install-class-based-resource branch 2 times, most recently from 66de733 to be3c785 Compare

June 18, 2023 13:05

github-actions bot commented Jul 3, 2023

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

github-actions bot added the abandoned label

github-actions bot removed the abandoned label

github-actions bot commented Jul 26, 2023

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

github-actions bot added the abandoned label

Member Author

johlju commented Sep 30, 2023

I'm gonna try to pick this up again, this is a very complex work, reimagine how Get-function works.

github-actions bot removed the abandoned label

johlju mentioned this pull request

There is no way to enable the necessary features of the SQL Server microsoft/winget-cli#3522

Open

github-actions bot commented Oct 16, 2023

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

github-actions bot added the abandoned label

johlju added 5 commits

December 16, 2023 09:33


          SqlInstall: New resource

ece6f39


          Fix comment-based help

f077c47


          Fix wrong comments

b782b28


          FIx bug in tests

70c8ec0


          Add private command Get-RegistryPropertyValue

517ac75

johlju added 11 commits

December 16, 2023 09:33


          Add private command ConvertFrom-ServiceStartMode

ab55d79


          Fix ignore spell of SSMS

3b5716c


          Add private command Get-InstanceId

c80a50e


          Changes to SqlInstall

de4289e


          Add public command Test-IsDataQualityClientInstalled


          First iteration of Get-SqlDscInstalledComponent

f4100f1


          Update Get-SqlDscInstalledComponent

e26f69c


          Fix more commands to test current state

ec52402


          Iteration 2

1fa0801


          Iteration 3

889524b


          Modify and add commands

f568f52

johlju force-pushed the f/install-class-based-resource branch from 1dac3e7 to f568f52 Compare

December 16, 2023 08:33

github-actions bot removed the abandoned label

github-actions bot commented Jan 1, 2024

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

github-actions bot added the abandoned label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment