Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NetAdapterRename] Allow rename with HyperV Device Naming #523

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nyanhp
Copy link
Contributor

@nyanhp nyanhp commented Apr 18, 2023

Pull Request (PR) description

On Hyper-V VMs, if Device Naming is configured, an advanced property is present that can be used to filter for
a NetAdapter renaming.

This Pull Request (PR) fixes the following issues

None

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation added/updated in README.md.
  • Resource parameter descriptions added/updated in README.md, schema.mof
    and comment-based help.
  • Comment-based help added/updated.
  • Localization strings added/updated in all localization files as appropriate.
  • Examples appropriately added/updated.
  • Unit tests added/updated. See DSC Community Testing Guidelines.
  • Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

@nyanhp
Copy link
Contributor Author

nyanhp commented Apr 18, 2023

Pipeline fails due to dsccommunity/DscResource.DocGenerator#131

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #523 (bdc3077) into main (9d6e70d) will increase coverage by 0%.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #523   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        28     28           
  Lines      2078   2081    +3     
===================================
+ Hits       2028   2031    +3     
  Misses       50     50           
Impacted Files Coverage Δ
...sources/DSC_NetAdapterName/DSC_NetAdapterName.psm1 100% <100%> (ø)
...les/NetworkingDsc.Common/NetworkingDsc.Common.psm1 96% <100%> (+<1%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant