Allow configuration of hidden network adapters #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor reformatting of code style.
Add -IncludeHidden parameter to helper function Find-NetworkAdapter with default to $true
Add IncludeHidden property to NetAdapterName resource, defaulting to $false
In Assert-ResourceProperty, use Find-NetworkAdapter instead of Get-NetAdapter.
Add -IncludeHidden:$true for all calls to *-NetAdapterAdvancedProperty
Add -IncludeHidden:$true to calls to *-NetAdapterBinding
In Get-Binding, use Find-NetworkAdapter instead of Get-NetAdapter.
Add -IncludeHidden:$true to calls of *-NetAdapterLso
Add -IncludeHidden:$true to calls of *-NetAdapterRdma
Add -IncludeHidden:$true on calls to *-NetAdapterRsc
Add -IncludeHidden:$true on calls to *-NetAdapterRss
In Get/Set-TargetResource, use Find-NetworkAdapter instead of Get-NetAdapter
Add -IncludeHidden:$true on calls to *-NetAdapter
In Assert-ResourceProperty, use Find-NetworkAdapter instead of Get-NetAdapter
In Assert-ResourceProperty, use Find-NetworkAdapter instead of Get-NetAdapter
In Assert-ResourceProperty, use Find-NetworkAdapter instead of Get-NetAdapter
|
Seems Find-NetworkAdapter doesn't throw the same as Get-NetAdapter...so I'll go figure that out next |
johlju
added
needs review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
NetAdapter module Cmdlets have an -IncludeHidden flag which allows access to adapters which are hidden; enable that flag by default except for NetAdapterName. Add IncludeHidden as configurable parameter to NetAdapterName.
NOTE: this is patch based off #496, so there's a lot of whitespace change. I made #496 specifically to make this diff much simpler.
This Pull Request (PR) fixes the following issues
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is