Launcher in French / Launcher en Français #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscalzi
reviewed
Dec 4, 2023
| checkingForUpdatesButton = "Recherche de mises à jours..." | ||
|
|
||
| [js.uibinder.startup] | ||
| fatalErrorTitle = "Fatal Error: Unable to Load Distribution Index" |
|
@GeekCornerGH what do you think? I'm wondering if we should add french as well since most forks are french users. |
|
@GeekCornerGH stp dit oui |
That's a good question. I don't think adding i18n should be in the scope of the project, but it's your project, so do whatever you want |
GeekCornerGH
suggested changes
Dec 24, 2023
There was a problem hiding this comment.
Review (biggest one I've ever done yet) is finally done, merry Christmas🎄🎉
To be honest, there were quite some grammar mistakes, while some sentences weren't making sense at all. And I probably missed some.
Have you done the translation through Google Translate by any luck?
| @@ -0,0 +1,281 @@ | |||
| [ejs.landing] | |||
| updateAvailableTooltip = "Mise à jour disponible" | |||
| usernamePlaceholder = "Username" | |||
There was a problem hiding this comment.
Suggested change
| usernamePlaceholder = "Username" | |
| usernamePlaceholder = "Nom d'utilisateur" |
| mojangStatusNETitle = "Non Essentiels" | ||
| newsButton = "ACTUALITÉES" | ||
| launchButton = "JOUER" | ||
| launchButtonPlaceholder = "• Aucun serveur sélectioner" |
There was a problem hiding this comment.
Suggested change
| launchButtonPlaceholder = "• Aucun serveur sélectioner" | |
| launchButtonPlaceholder = "• Aucun serveur sélectioné" |
| launchButtonPlaceholder = "• Aucun serveur sélectioner" | ||
| launchDetails = "Chargement.." | ||
| newsNavigationStatus = "{currentPage} / {totalPages}" | ||
| newsErrorLoadSpan = "Chargement des actualitées.." |
There was a problem hiding this comment.
Suggested change
| newsErrorLoadSpan = "Chargement des actualitées.." | |
| newsErrorLoadSpan = "Chargement des actualités.." |
| newsErrorLoadSpan = "Chargement des actualitées.." | ||
| newsErrorFailedSpan = "Erreur lors du chargements" | ||
| newsErrorRetryButton = "Réessayer" | ||
| newsErrorNoneSpan = "Aucune actualitée" |
There was a problem hiding this comment.
Suggested change
| newsErrorNoneSpan = "Aucune actualitée" | |
| newsErrorNoneSpan = "Aucune actualité" |
| launchDetails = "Chargement.." | ||
| newsNavigationStatus = "{currentPage} / {totalPages}" | ||
| newsErrorLoadSpan = "Chargement des actualitées.." | ||
| newsErrorFailedSpan = "Erreur lors du chargements" |
There was a problem hiding this comment.
Suggested change
| newsErrorFailedSpan = "Erreur lors du chargements" | |
| newsErrorFailedSpan = "Erreur lors du chargement" |
|
|
||
| [js.uibinder.validateAccount] | ||
| failedMessageTitle = "Failed to Refresh Login" | ||
| failedMessage = "We were unable to refresh the login for <strong>{account}</strong>. Please select another account or login again." |
There was a problem hiding this comment.
Suggested change
| failedMessage = "We were unable to refresh the login for <strong>{account}</strong>. Please select another account or login again." | |
| failedMessage = "Nous n'avons pas pu actualiser le compte <strong>{account}</strong>. Veuillez sélectionner un autre compte, ou reconnectez-vous." |
| [js.uibinder.validateAccount] | ||
| failedMessageTitle = "Failed to Refresh Login" | ||
| failedMessage = "We were unable to refresh the login for <strong>{account}</strong>. Please select another account or login again." | ||
| failedMessageSelectAnotherAccount = "We were unable to refresh the login for <strong>{account}</strong>. Please login again." |
There was a problem hiding this comment.
Suggested change
| failedMessageSelectAnotherAccount = "We were unable to refresh the login for <strong>{account}</strong>. Please login again." | |
| failedMessageSelectAnotherAccount = "Nous n'avons pas pu actualiser le compte <strong>{account}</strong>. Veuillez vous reconnecter." |
| failedMessage = "We were unable to refresh the login for <strong>{account}</strong>. Please select another account or login again." | ||
| failedMessageSelectAnotherAccount = "We were unable to refresh the login for <strong>{account}</strong>. Please login again." | ||
| loginButton = "Se connecter" | ||
| selectAnotherAccountButton = "Sélectioner un autre compte" |
There was a problem hiding this comment.
Suggested change
| selectAnotherAccountButton = "Sélectioner un autre compte" | |
| selectAnotherAccountButton = "Sélectionner un autre compte" |
| selectAnotherAccountButton = "Sélectioner un autre compte" | ||
|
|
||
| [js.uicore.autoUpdate] | ||
| checkingForUpdateButton = "Recherche de mises à jours..." |
There was a problem hiding this comment.
Suggested change
| checkingForUpdateButton = "Recherche de mises à jours..." | |
| checkingForUpdateButton = "Recherche de mises à jour.." |
| [js.uicore.autoUpdate] | ||
| checkingForUpdateButton = "Recherche de mises à jours..." | ||
| installNowButton = "Installer maintenant" | ||
| checkForUpdatesButton = "Rechercher pour des mises à jours" |
There was a problem hiding this comment.
Suggested change
| checkForUpdatesButton = "Rechercher pour des mises à jours" | |
| checkForUpdatesButton = "Rechercher pour des mises à jour" |
sheazywi
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added and translated the en_US.toml file in French to make fr_FR.toml.