Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#549] Update ScriptHandler.php to check for symlinks before creating files directory #551

Merged
merged 1 commit into from May 13, 2024
Merged

[#549] Update ScriptHandler.php to check for symlinks before creating files directory #551

merged 1 commit into from May 13, 2024

Conversation

SkywardRay
Copy link
Contributor

@SkywardRay SkywardRay commented Jan 17, 2020 •
edited by AlexSkrypnyk

Closes #549

When using drupal inside a docker container it can be useful to make the sites/default/files directory a symlink instead. For example here in the wodby documentation https://wodby.com/docs/stacks/drupal/#files_1

I propose adding a check to is_link to prevent errors caused by $fs->exists not handling symlinks.

@SkywardRay
Update ScriptHandler.php to check for symlinks before creating files …
c6d466b 
…directory

When using drupal inside a docker container it can be useful to make the sites/default/files directory a symlink instead. For example here in the wodby documentation https://wodby.com/docs/stacks/drupal/#files_1

I propose adding a check to is_link to prevent errors caused by $fs->exists not handling symlinks.
@SkywardRay SkywardRay mentioned this pull request Jan 17, 2020
Closed
@AlexSkrypnyk AlexSkrypnyk self-assigned this May 12, 2024
leymannx
leymannx approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@leymannx leymannx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think we should then get this in 9.x, 10.x and 11.x as well.

@AlexSkrypnyk AlexSkrypnyk added the PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request label May 13, 2024
@AlexSkrypnyk AlexSkrypnyk changed the base branch from 8.x to 10.x May 13, 2024 21:04
@AlexSkrypnyk AlexSkrypnyk self-requested a review May 13, 2024 21:05
@AlexSkrypnyk AlexSkrypnyk merged commit 41336b7 into drupal-composer:10.x May 13, 2024
@AlexSkrypnyk AlexSkrypnyk added PR: Ready to be merged Pull request is ready to be merged (assigned after testing is complete) and removed PR: Requires more work Pull request was reviewed and reviver(s) asked to work further on the pull request labels May 13, 2024
@AlexSkrypnyk
Copy link
Collaborator

I've pushed to 10.x and 11.x. I think we decided to support only current and the next version of core. Happy to discuss this offline and commit this to other branches.

@AlexSkrypnyk AlexSkrypnyk changed the title Update ScriptHandler.php to check for symlinks before creating files directory [#549] Update ScriptHandler.php to check for symlinks before creating files directory May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSkrypnyk AlexSkrypnyk AlexSkrypnyk approved these changes

@leymannx leymannx leymannx approved these changes

@webflo webflo Awaiting requested review from webflo

Assignees

@AlexSkrypnyk AlexSkrypnyk

Labels
PR: Ready to be merged Pull request is ready to be merged (assigned after testing is complete)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ScriptHandler to support symlinks
3 participants
@SkywardRay @AlexSkrypnyk @leymannx