New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drupal-composer/drupal-project has [not] been deprecated #550
Conversation
Its not deprecated for me. The official template is in its infancy and I predict it will take years to achieve parity. This template has a batteries-included approach such as built in support for .env files, drush+drupal-console, ... |
Where does this deprecation statement come from? |
It come from drupal.org official doc. Perhaps another wording would be more
appropriate to reflect this project is still actively developed.
But really I believe having one "official" way help a lot people not
familiar with Drupal. So a notice is certainly beneficial.
…On Thu, Jan 16, 2020, 15:56 Norman Kämper-Leymann ***@***.***> wrote:
Where does this deprecation statement come from?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#550?email_source=notifications&email_token=AABIB2W3E7G3HCPMUQKBQATQ6BYRDA5CNFSM4KHTZM6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJEK65A#issuecomment-575188852>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABIB2RFLTF6MSGR3J4GIP3Q6BYRDANCNFSM4KHTZM6A>
.
|
I can't find anything anywhere stating that this template should be considered deprecated. It even reflects the latest changes when using the core scaffold and core dev meta packages. Please also have a look at #538 |
So I guess the situation is not 100% clear and I get confused too (and a lot more will). From https://www.drupal.org/docs/develop/using-composer/using-composer-to-install-drupal-and-manage-dependencies#download-core Do you have a proposition to make the situation clearer in the readme? Agree deprecated is not good (as it still supported) but what about "unofficial"? And explain what kind of extra features it bring? |
So, just a comment about the documentation quoted above:
At the time that was written, drupal-composer/drupal-project was still using drupal-composer/drupal-scaffold, which we strongly want to deprecate. Now that drupal-composer/drupal-project is using drupal/core-composer-scaffold, just as drupal/recommended-project is, that message is misleading. We should probably rewrite it to help guide folks to the right path. Eventually we'll have a conversion tool, which could potentially be smart about looking at what is in the source site and adapting it to use the latest recommended components. Once we're at that point, we'll have a recommended upgrade path that is easy to describe. Right now, it is not super clear. |
Composer command line also throws a warning saying this package is deprecated/obsoleted (can't remember which one), and recommends a removal |
@skyred – Which "this" package are you referring to? |
@skyred is perhaps referring to webflo/drupal-dev-dependencies, which was used in older versions of drupal-composer/drupal-project, and is in fact deprecated, no longer maintained, and should be removed. Replace it with drupal/core-dev, as this project has done in the current HEAD of master. If you are using webflo/drupal-core-strict, replace it with drupal/core-recommended (and also remove drupal/core). |
You guys are aware than except the couples of people that build those tools, nobody can understand what's going on and what they should use? So can we add somethings in the readme? What should we recommend today for someone that want to install and manage Drupal using composer? I'm proposing something like that:
A table that compare the features of the different projects would be great. But this warning should be enough for new user. |
Yes, we are aware that more documentation and more help (e.g. a converter tool) is necessary. Thanks to all who help close these gaps. |
I'd suggest that drupal-composer/drupal-project is better for beginners as it has some sane defaults, or "batteries included" as others have suggested. |
I can see why Drupal wants to maintain https://github.com/drupal/recommended-project and https://github.com/drupal/legacy-project. What I can't understand is why they are officially recommended by Drupal. They don't even have a README. https://github.com/drupal-composer/drupal-project is light years ahead and should be officially recommended in my opinion. |
This pull request/issue has been inactive for over a year and is being closed due to inactivity. If the issue still persists or the contribution is still relevant, please feel free to reopen it or create a new one. Thank you for your understanding and your contributions to the project! |
As of the release of Drupal 8.8.0 - the recommend composer template changed from drupal-composer/drupal-project to the officially supported: drupal/recommended-project
I think this should be indicated in the readme.