Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drupal-composer/drupal-project has [not] been deprecated #550

Closed
wants to merge 1 commit into from
Closed

drupal-composer/drupal-project has [not] been deprecated #550

wants to merge 1 commit into from

Conversation

gagarine
Copy link
Contributor

As of the release of Drupal 8.8.0 - the recommend composer template changed from drupal-composer/drupal-project to the officially supported: drupal/recommended-project

I think this should be indicated in the readme.

@weitzman
Copy link
Contributor

Its not deprecated for me. The official template is in its infancy and I predict it will take years to achieve parity. This template has a batteries-included approach such as built in support for .env files, drush+drupal-console, ...

@leymannx
Copy link
Collaborator

Where does this deprecation statement come from?

@gagarine
Copy link
Contributor Author

gagarine commented Jan 16, 2020 via email

@leymannx
Copy link
Collaborator

I can't find anything anywhere stating that this template should be considered deprecated. It even reflects the latest changes when using the core scaffold and core dev meta packages.

Please also have a look at #538

@gagarine
Copy link
Contributor Author

So I guess the situation is not 100% clear and I get confused too (and a lot more will). From https://www.drupal.org/docs/develop/using-composer/using-composer-to-install-drupal-and-manage-dependencies#download-core
Screenshot 2020-01-16 at 23 31 57

Do you have a proposition to make the situation clearer in the readme? Agree deprecated is not good (as it still supported) but what about "unofficial"? And explain what kind of extra features it bring?

@greg-1-anderson
Copy link
Collaborator

So, just a comment about the documentation quoted above:

As of the release of Drupal 8.8.0 - the recommended composer template changed from drupal-composer/drupal-project to the officially supported: drupal/recommended-project

At the time that was written, drupal-composer/drupal-project was still using drupal-composer/drupal-scaffold, which we strongly want to deprecate. Now that drupal-composer/drupal-project is using drupal/core-composer-scaffold, just as drupal/recommended-project is, that message is misleading. We should probably rewrite it to help guide folks to the right path.

Eventually we'll have a conversion tool, which could potentially be smart about looking at what is in the source site and adapting it to use the latest recommended components. Once we're at that point, we'll have a recommended upgrade path that is easy to describe. Right now, it is not super clear.

@skyred
Copy link

skyred commented Feb 13, 2020

Composer command line also throws a warning saying this package is deprecated/obsoleted (can't remember which one), and recommends a removal

@leymannx
Copy link
Collaborator

@skyred – Which "this" package are you referring to?

@greg-1-anderson
Copy link
Collaborator

greg-1-anderson commented Feb 13, 2020

@skyred is perhaps referring to webflo/drupal-dev-dependencies, which was used in older versions of drupal-composer/drupal-project, and is in fact deprecated, no longer maintained, and should be removed. Replace it with drupal/core-dev, as this project has done in the current HEAD of master.

If you are using webflo/drupal-core-strict, replace it with drupal/core-recommended (and also remove drupal/core).

@gagarine
Copy link
Contributor Author

You guys are aware than except the couples of people that build those tools, nobody can understand what's going on and what they should use?

So can we add somethings in the readme? What should we recommend today for someone that want to install and manage Drupal using composer?

I'm proposing something like that:

**Warning**: As of Drupal 8.8.0 the recommended approach (especially for beginners to Composer) is to use the [composer template at drupal/recommended-project](https://www.drupal.org/docs/develop/using-composer/using-composer-to-install-drupal-and-manage-dependencies).

A table that compare the features of the different projects would be great. But this warning should be enough for new user.

@greg-1-anderson
Copy link
Collaborator

Yes, we are aware that more documentation and more help (e.g. a converter tool) is necessary. Thanks to all who help close these gaps.

@mstrelan
Copy link

Warning: As of Drupal 8.8.0 the recommended approach (especially for beginners to Composer) is to use the composer template at drupal/recommended-project.

I'd suggest that drupal-composer/drupal-project is better for beginners as it has some sane defaults, or "batteries included" as others have suggested.

@greg-1-anderson greg-1-anderson changed the title drupal-composer/drupal-project has been deprecated drupal-composer/drupal-project has [not] been deprecated Mar 11, 2020
@guix77
Copy link

guix77 commented May 4, 2020

I can see why Drupal wants to maintain https://github.com/drupal/recommended-project and https://github.com/drupal/legacy-project.

What I can't understand is why they are officially recommended by Drupal. They don't even have a README.

https://github.com/drupal-composer/drupal-project is light years ahead and should be officially recommended in my opinion.

@AlexSkrypnyk
Copy link
Collaborator

This pull request/issue has been inactive for over a year and is being closed due to inactivity. If the issue still persists or the contribution is still relevant, please feel free to reopen it or create a new one.

Thank you for your understanding and your contributions to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants