Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lando config #483

Closed
wants to merge 3 commits into from
Closed

Add lando config #483

wants to merge 3 commits into from

Conversation

geekygnr
Copy link

@geekygnr geekygnr commented Apr 9, 2019

I thought it would be helpful if the repo had a very basic lando configuration. I would encourage similar done for all common tools for quick dev environment setup.

@leymannx
Copy link
Collaborator

leymannx commented Apr 10, 2019

👍 Nice to have, yes. But environment is totally up to every developer themself and goes beyond the scope of this template I guess.

@truls1502
Copy link

👍 Nice to have, yes. But environment is totally up to every developer themself and goes beyond the scope of this template I guess.

I am totally agreed with you, @leymannx that it should be up to every developer.
However, I believe it would be nice to have some popular recipes for development environments such as DDEV and Lando to let the new beginner try to spin up the Drupal site in just a few secs. It could save a lot of their time, especially first time so they can play more with Drupal then later they can customise after their need. For the advanced developers so we can create a patch with our own customised on these development environments.

@geekygnr
Copy link
Author

@truls1502 Thank you. I think you put my thought process down in a far more elegant way than I ever could.

@AlexSkrypnyk
Copy link
Collaborator

@truls1502 Currently, most of the code in the repo is covered with tests. How would you check that what you are proposing is working in CI?

I think this project is not a place for development environment configurations.

@AlexSkrypnyk
Copy link
Collaborator

This pull request/issue has been inactive for over a year and is being closed due to inactivity. If the issue still persists or the contribution is still relevant, please feel free to reopen it or create a new one.

Thank you for your understanding and your contributions to the project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants