Modify the default settings so that if patches cannot be applied the composer install step fails. #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…composer install step fails. As found on the readme of the "composer-patches" package, the default behaviour is that a patch cannot be applied the build is allowed to continue. In my opinion that is not a useful behaviour to have because unpatched modules and core might end up in production, so I propose to set this setting to "TRUE" so that if patching fails the build is not allowed to go through. People would still be able to remove that to get the old behaviour if desired. More info on the readme of the composer-patches package at: https://github.com/cweagans/composer-patches#error-handling
|
This would be very nice to have. If we set this option this will make sure that people that are not aware of this option will not accidentally generate invalid builds if a patch cannot be downloaded for some reason. In the next major version of composer-patches this option will be set by default. Ref. cweagans/composer-patches#209 |
|
@vermario is it possible for you to update the PR and solve the merge conflict? The failure that happened seems to be unrelated. |
|
This was added to 10.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I propose this small change:
As found on the readme of the "composer-patches" package, the default behaviour is that a patch cannot be applied the build is allowed to continue.
In my opinion that is not a useful behaviour to have as the default because unpatched modules and core might end up in production, so I propose to set this setting to "TRUE" so that if patching fails the build is not allowed to go through.
People would still be able to remove that to get the old behaviour if desired.
More info on the readme of the composer-patches package at: https://github.com/cweagans/composer-patches#error-handling