Add canvasFill option
#2241
Open
Add canvasFill option
#2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crespire
changed the title
crespire
force-pushed
the
simmon/add-white-bg
branch
from
348b6e4
to
26f6b03
Compare
crespire
changed the title
crespire
changed the title
canvasFill option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that when converting PNG with transparency to a JPG, the image ended up with a black background.
I added this as a proof-of-concept, but it really should be a configuration option. If this idea is worthwhile, I'm happy to pursue it via using an option likeresizeCanvasBackgroundor something like that.I ended up implementing
canvasFillas an option.